List models using open ai api #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccelerated-data-science into track_md_logs_for_error_logging
…o list_models_using_openAI_API
…-science into list_models_using_openAI_API
…racle/accelerated-data-science into list_models_using_openAI_API
…racle/accelerated-data-science into list_models_using_openAI_API
agrimk
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Jul 22, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
ads/aqua/client/client.py
Outdated
| @@ -582,6 +582,19 @@ def embeddings( | |||
| payload = {**(payload or {}), "input": input} | |||
| return self._request(payload=payload, headers=headers) | |||
|
|
|||
| def list_models(self) -> Union[Dict[str, Any], Iterator[Mapping[str, Any]]]: | |||
There was a problem hiding this comment.
the logic in this method here seems generic, should we call it fetch_data or get_json_response instead oflist_models? Also, docstrings need to be changed here.
| self.set_header("Content-Type", "application/json") | ||
| endpoint: str = "" | ||
| model_deployment = AquaDeploymentApp().get(model_deployment_id) | ||
| if model_deployment.endpoint.endswith("/"): |
There was a problem hiding this comment.
we can simplify this with something like:
endpoint = model_deployment.endpoint.rstrip("/") + "/predict/v1/models"
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
previously approved these changes
Jul 30, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
previously approved these changes
Jul 30, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Jul 30, 2025
vikasray0208
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BASEURL/aqua/deployments/models/list/<md_ocid>